Bug 1822118 - display: inline list-item is also a line participant. r=jfkthame,#layout
ClosedPublic
Actions

Authored by emilio on May 3 2023, 7:07 PM.

Details

Reviewers

jfkthame
dshin

Group Reviewers

layout-reviewers

Commits

rMOZILLACENTRAL2803e9d5d312: Bug 1822118 - display: inline list-item is also a line participant. r=dshin

Bugzilla Bug ID

1822118

Summary

So the line break suppression flags should be propagated through it.

Otherwise ruby invariants might break, leading to a nullptr crash in
this case.

On debug builds the assertion was this one:

https://searchfox.org/mozilla-central/rev/e6cb503ac22402421186e7488d4250cc1c5fecab/layout/generic/nsRubyBaseContainerFrame.cpp#631

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 535875
Build 632939: arc lint + arc unit

Event Timeline

emilio created this revision.May 3 2023, 7:07 PM

Herald added a project: secure-revision. · View Herald TranscriptMay 3 2023, 7:07 PM

Harbormaster completed remote builds in B533331: Diff 711966.May 3 2023, 7:07 PM

phab-bot published this revision for review.May 3 2023, 7:09 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

dshin accepted this revision as: dshin.May 10 2023, 1:18 PM

This revision is now accepted and ready to land.May 10 2023, 1:18 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!