Page MenuHomePhabricator
Differential D177074

Bug 1778909 - Add an API to parse an absolute length without any other context. r=jfkthame
ClosedPublic
Actions

Authored by emilio on May 3 2023, 5:34 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Apr 10, 3:33 PM
Unknown Object (File)
Thu, Apr 9, 11:47 PM
Unknown Object (File)
Sat, Apr 4, 10:21 AM
Unknown Object (File)
Wed, Apr 1, 4:00 PM
Unknown Object (File)
Tue, Mar 31, 5:40 PM
Unknown Object (File)
Sat, Mar 28, 10:12 PM
Unknown Object (File)
Sat, Mar 28, 10:05 AM
Unknown Object (File)
Fri, Mar 27, 6:22 PM
View All 20 Files
Subscribers
None

Details

Reviewers
jfkthame
Commits
rMOZILLACENTRALb3fb213b502f: Bug 1778909 - Add an API to parse an absolute length without any other context.
Bugzilla Bug ID
1778909
Summary

This should allow making these work on canvas.

Diff Detail

Event Timeline

emilio created this revision.May 3 2023, 5:34 PM
Herald added a project: secure-revision. · View Herald TranscriptMay 3 2023, 5:34 PM
Harbormaster completed remote builds in B533272: Diff 711911.May 3 2023, 5:34 PM
phab-bot published this revision for review.May 3 2023, 5:35 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
jfkthame accepted this revision.May 10 2023, 11:05 PM
jfkthame added a project: testing-exception-unchanged (Doesn't change behavior for users).

This seems fine as a start, though I do think we should aim to support font-relative units as a followup enhancement.

This revision is now accepted and ready to land.May 10 2023, 11:05 PM
jfkthame added a child revision: D177019: Bug 1778909 - Implement letterSpacing and wordSpacing attributes for Canvas2D text. r=#layout-reviewers.May 10 2023, 11:10 PM
Closed by commit rMOZILLACENTRALb3fb213b502f: Bug 1778909 - Add an API to parse an absolute length without any other context. (authored by emilio). · Explain WhyMay 10 2023, 11:16 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRALb3fb213b502f: Bug 1778909 - Add an API to parse an absolute length without any other context..

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
values/
specified/
10 lines71%
Loading...
ports/
geckolib/
50 lines95%
Loading...

Diff 714978

View Options

servo/components/style/values/specified/length.rs

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
Privacy · Cookies · Legal