Page MenuHomePhabricator
Differential D176793

Bug 1830656 - Refactor ImportLayer into enum
ClosedPublic
Actions

Authored by • canadahonk on Apr 30 2023, 7:27 PM.
Tags
Referenced Files
Unknown Object (File)
Nov 15 2025, 11:58 AM
Unknown Object (File)
Nov 15 2025, 3:33 AM
Unknown Object (File)
Nov 14 2025, 12:36 AM
Unknown Object (File)
Nov 13 2025, 10:36 AM
Unknown Object (File)
Nov 9 2025, 1:19 AM
Unknown Object (File)
Nov 4 2025, 10:27 PM
Unknown Object (File)
Nov 4 2025, 10:23 PM
Unknown Object (File)
Oct 15 2025, 3:13 PM
View All 46 Files
Subscribers
emilio
reviewbot
tlouw

Details

Reviewers
emilio
Group Reviewers
layout-reviewers
Commits
rMOZILLACENTRALd5bfc83882dd: Bug 1830656 - Refactor ImportLayer into enum r=emilio
rMOZILLACENTRAL155b9abe4a7e: Bug 1830656 - Refactor ImportLayer into enum r=emilio
rMOZILLACENTRAL8b600348f317: Bug 1830656 - Refactor ImportLayer into enum r=emilio
Bugzilla Bug ID
1830656
Summary

Refactored ImportLayer into an enum instead of a struct and using
Option everywhere.

Diff Detail

Event Timeline

• canadahonk created this revision.Apr 30 2023, 7:27 PM
Herald added a project: secure-revision. · View Herald TranscriptApr 30 2023, 7:27 PM
Harbormaster completed remote builds in B532181: Diff 710526.Apr 30 2023, 7:27 PM
phab-bot published this revision for review.Apr 30 2023, 7:27 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptApr 30 2023, 7:27 PM
• canadahonk edited the summary of this revision. (Show Details)Apr 30 2023, 8:27 PM
• canadahonk added a reviewer: layout-reviewers.
tlouw added a subscriber: tlouw.May 1 2023, 9:32 AM

Nice refactor, small comment on enum matching.

servo/components/style/stylesheets/import_rule.rs
282

The more idiomatic way to check a certain enum would be:

if matches!(self.layer, ImportLayer::None) { .. }

That way you can also remove the PartialEq derive from ImportLayer.

• canadahonk updated this revision to Diff 710580.May 1 2023, 11:34 AM
• canadahonk edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B532220: Diff 710580.May 1 2023, 11:35 AM
• canadahonk marked an inline comment as done.May 1 2023, 11:35 AM
• canadahonk added inline comments.
servo/components/style/stylesheets/import_rule.rs
282

Thanks, done.

reviewbot added a subscriber: reviewbot.May 1 2023, 12:02 PM

The analysis task source-test-mozlint-file-perm failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-mozlint-file-whitespace failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-mozlint-rustfmt failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

emilio accepted this revision as: emilio.May 1 2023, 12:53 PM
emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).

Looks great, thanks!

This revision is now accepted and ready to land.May 1 2023, 12:53 PM
• canadahonk marked an inline comment as done.May 1 2023, 2:05 PM
Closed by commit rMOZILLACENTRAL8b600348f317: Bug 1830656 - Refactor ImportLayer into enum r=emilio (authored by • canadahonk). · Explain WhyMay 1 2023, 2:32 PM
This revision was automatically updated to reflect the committed changes.
• canadahonk added a commit: rMOZILLACENTRAL8b600348f317: Bug 1830656 - Refactor ImportLayer into enum r=emilio.
• nataliaCs reopened this revision.May 1 2023, 3:49 PM
This revision is now accepted and ready to land.May 1 2023, 3:49 PM
• nataliaCs added a reverting change: rMOZILLACENTRALcef2da083ee9: Backed out changeset 8b600348f317 (bug 1830656) for causing failures on….May 1 2023, 3:49 PM
• canadahonk updated this revision to Diff 710624.May 1 2023, 4:07 PM
Harbormaster completed remote builds in B532252: Diff 710624.May 1 2023, 4:07 PM
Closed by commit rMOZILLACENTRAL155b9abe4a7e: Bug 1830656 - Refactor ImportLayer into enum r=emilio (authored by • canadahonk). · Explain WhyMay 1 2023, 5:17 PM
This revision was automatically updated to reflect the committed changes.
• canadahonk added a commit: rMOZILLACENTRAL155b9abe4a7e: Bug 1830656 - Refactor ImportLayer into enum r=emilio.
smolnar reopened this revision.May 1 2023, 7:43 PM
This revision is now accepted and ready to land.May 1 2023, 7:43 PM
smolnar added a reverting change: rMOZILLACENTRAL4c02b4f816ec: Backed out changeset 155b9abe4a7e (bug 1830656) for causing dt and wpt failures….May 1 2023, 7:43 PM
• canadahonk updated this revision to Diff 710696.May 1 2023, 8:10 PM
Harbormaster completed remote builds in B532314: Diff 710696.May 1 2023, 8:10 PM
Closed by commit rMOZILLACENTRALd5bfc83882dd: Bug 1830656 - Refactor ImportLayer into enum r=emilio (authored by • canadahonk). · Explain WhyMay 1 2023, 10:41 PM
This revision was automatically updated to reflect the committed changes.
• canadahonk added a commit: rMOZILLACENTRALd5bfc83882dd: Bug 1830656 - Refactor ImportLayer into enum r=emilio.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
stylesheets/
35 lines81%
Loading...
2 lines--
2 lines94%
Loading...
7 lines86%
Loading...
ports/
geckolib/
8 lines97%
Loading...
4 lines93%
Loading...

Diff 710751

View Options

servo/components/style/stylesheets/import_rule.rs

Loading...
View Options

servo/components/style/stylesheets/loader.rs

Loading...
View Options

servo/components/style/stylesheets/rule_parser.rs

Loading...
View Options

servo/components/style/stylist.rs

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
View Options

servo/ports/geckolib/stylesheet_loader.rs

Loading...
Privacy · Cookies · Legal