Differential D176686

Bug 1830369 - [css-nesting] Update cssparser to allow parsing qualified rules along with declarations. r=tlouw,#style,#layout
ClosedPublic
Actions

Authored by emilio on Apr 27 2023, 4:36 PM.

Details

Reviewers

tlouw

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRAL295ccc005c4f: Bug 1830369 - [css-nesting] Update cssparser to allow parsing qualified rules…

Bugzilla Bug ID

1830369

Summary

No implementation just yet (the default QualifiedRuleParser
implementation just rejects stuff), but this is plumbing that I'd rather
get reviewed separately.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 532175
Build 629143: arc lint + arc unit

Event Timeline

emilio created this revision.Apr 27 2023, 4:36 PM

Herald added a project: secure-revision. · View Herald TranscriptApr 27 2023, 4:36 PM

Harbormaster completed remote builds in B531798: Diff 710116.Apr 27 2023, 4:36 PM

phab-bot published this revision for review.Apr 27 2023, 4:37 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: glandium. · View Herald TranscriptApr 27 2023, 4:37 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

emilio added a parent revision: D176560: Bug 1830134 - [css-nesting] Process nested rules at cascade data rebuild. r=#style,#layout.Apr 27 2023, 5:18 PM

bholley requested changes to this revision.Apr 27 2023, 5:19 PM

bholley added a subscriber: bholley.

bholley added inline comments.

supply-chain/audits.toml
602–608	Seems like these are all effectively duplicates of each other, and that all but one of them can be removed?

This revision now requires changes to proceed.Apr 27 2023, 5:19 PM

emilio requested review of this revision.Apr 27 2023, 5:23 PM

emilio updated this revision to Diff 710156.

Harbormaster completed remote builds in B531823: Diff 710156.Apr 27 2023, 5:23 PM

emilio marked an inline comment as done.Apr 27 2023, 5:24 PM

emilio added inline comments.

supply-chain/audits.toml
602–608	Yes, indeed.

emilio marked an inline comment as done.Apr 27 2023, 5:24 PM

bholley accepted this revision as: Restricted Project.Apr 27 2023, 5:28 PM

bholley removed a reviewer: bholley.

emilio added 2 blocking reviewer(s): layout-reviewers, Restricted Project.Apr 27 2023, 5:32 PM

Too bad about the white space changes, but lgtm.

emilio updated this revision to Diff 710502.Apr 29 2023, 6:19 PM

Harbormaster completed remote builds in B532161: Diff 710502.Apr 29 2023, 6:19 PM

I assume glandium was tagged for Cargo.lock or so changes, which are only hash changes.

This revision is now accepted and ready to land.Apr 29 2023, 6:20 PM

The analysis task source-test-mozlint-rustfmt failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-mozlint-clippy failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Closed by commit rMOZILLACENTRAL295ccc005c4f: Bug 1830369 - [css-nesting] Update cssparser to allow parsing qualified rules… (authored by emilio). · Explain WhyApr 29 2023, 6:36 PM

This revision was automatically updated to reflect the committed changes.

emilio added a commit: rMOZILLACENTRAL295ccc005c4f: Bug 1830369 - [css-nesting] Update cssparser to allow parsing qualified rules….

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

.cargo/

config.in

4 lines

Cargo.lock

Cargo.toml

2 lines

servo/

components/

malloc_size_of/

Cargo.toml

2 lines

selectors/

Cargo.toml

2 lines

style/

Cargo.toml

2 lines

counter_style/

mod.rs

8 lines

96%

font_face.rs

16 lines

93%

properties/

declaration_block.rs

43 lines

89%

stylesheets/

font_feature_values_rule.rs

13 lines

89%

keyframes_rule.rs

6 lines

87%

viewport_rule.rs

12 lines

style_traits/

Cargo.toml

2 lines

to_shmem/

Cargo.toml

2 lines

ports/

geckolib/

Cargo.toml

2 lines

tests/

unit/

style/

Cargo.toml

2 lines

supply-chain/

audits.toml

22 lines

third_party/

rust/

cssparser/

.cargo-checksum.json

2 lines

.github/

workflows/

main.yml

6 lines

Cargo.toml

4 lines

src/

color.rs

89 lines

85%

cow_rc_str.rs

1 line

71%

lib.rs

4 lines

macros.rs

37 lines

100%

parser.rs

40 lines

94%

rules_and_declarations.rs

105 lines

89%

tests.rs

3 lines

tokenizer.rs

1 line

Diff 710503

View Options

.cargo/config.in

View Options

Cargo.lock

View Options

Cargo.toml

View Options

servo/components/malloc_size_of/Cargo.toml

View Options

servo/components/selectors/Cargo.toml

View Options

servo/components/style/Cargo.toml

View Options

servo/components/style/counter_style/mod.rs

View Options

servo/components/style/font_face.rs

View Options

servo/components/style/properties/declaration_block.rs

View Options

servo/components/style/stylesheets/font_feature_values_rule.rs

View Options

servo/components/style/stylesheets/keyframes_rule.rs

View Options

servo/components/style/stylesheets/viewport_rule.rs

View Options

servo/components/style_traits/Cargo.toml

View Options

servo/components/to_shmem/Cargo.toml

View Options

servo/ports/geckolib/Cargo.toml

View Options

servo/tests/unit/style/Cargo.toml

View Options

supply-chain/audits.toml

View Options

third_party/rust/cssparser/.cargo-checksum.json

View Options

third_party/rust/cssparser/.github/workflows/main.yml

View Options

third_party/rust/cssparser/Cargo.toml

View Options

third_party/rust/cssparser/src/color.rs

View Options

third_party/rust/cssparser/src/cow_rc_str.rs

View Options

third_party/rust/cssparser/src/lib.rs

View Options

third_party/rust/cssparser/src/macros.rs

View Options

third_party/rust/cssparser/src/parser.rs

View Options

third_party/rust/cssparser/src/rules_and_declarations.rs

View Options

third_party/rust/cssparser/src/tests.rs

View Options

third_party/rust/cssparser/src/tokenizer.rs

Bug 1830369 - [css-nesting] Update cssparser to allow parsing qualified rules along with declarations. r=tlouw,#style,#layoutClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 710503

.cargo/config.in

Cargo.lock

Cargo.toml

servo/components/malloc_size_of/Cargo.toml

servo/components/selectors/Cargo.toml

servo/components/style/Cargo.toml

servo/components/style/counter_style/mod.rs

servo/components/style/font_face.rs

servo/components/style/properties/declaration_block.rs

servo/components/style/stylesheets/font_feature_values_rule.rs

servo/components/style/stylesheets/keyframes_rule.rs

servo/components/style/stylesheets/viewport_rule.rs

servo/components/style_traits/Cargo.toml

servo/components/to_shmem/Cargo.toml

servo/ports/geckolib/Cargo.toml

servo/tests/unit/style/Cargo.toml

supply-chain/audits.toml

third_party/rust/cssparser/.cargo-checksum.json

third_party/rust/cssparser/.github/workflows/main.yml

third_party/rust/cssparser/Cargo.toml

third_party/rust/cssparser/src/color.rs

third_party/rust/cssparser/src/cow_rc_str.rs

third_party/rust/cssparser/src/lib.rs

third_party/rust/cssparser/src/macros.rs

third_party/rust/cssparser/src/parser.rs

third_party/rust/cssparser/src/rules_and_declarations.rs

third_party/rust/cssparser/src/tests.rs

third_party/rust/cssparser/src/tokenizer.rs

Bug 1830369 - [css-nesting] Update cssparser to allow parsing qualified rules along with declarations. r=tlouw,#style,#layout
ClosedPublic
Actions

Revision Contents
Changeset List