Page MenuHomePhabricator
Differential D175707

Bug 1814444 - Part 2: Support self keyword for scroll().
ClosedPublic
Actions

Authored by boris on Apr 17 2023, 9:39 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Mar 30, 9:55 PM
Unknown Object (File)
Tue, Mar 24, 4:40 PM
Unknown Object (File)
Mar 12 2026, 1:40 PM
Unknown Object (File)
Dec 6 2025, 12:58 PM
Unknown Object (File)
Oct 15 2025, 10:25 AM
Unknown Object (File)
Oct 14 2025, 8:26 PM
Unknown Object (File)
Oct 14 2025, 7:48 AM
Unknown Object (File)
Jun 2 2025, 5:01 PM
View All 16 Files
Subscribers
emilio

Details

Reviewers
emilio
Group Reviewers
layout-reviewers
Commits
rMOZILLACENTRALdf49bdfbde87: Bug 1814444 - Part 2: Support self keyword for scroll(). r=emilio
Bugzilla Bug ID
1814444
Summary

self keyword specifies to use the element’s own principal box as the
scroll container. If the principal box is not a scroll container, then the
scroll progress timeline is inactive.

Diff Detail

Event Timeline

boris created this revision.Apr 17 2023, 9:39 PM
Herald added a project: secure-revision. · View Herald TranscriptApr 17 2023, 9:39 PM
Harbormaster completed remote builds in B528075: Diff 705733.Apr 17 2023, 9:39 PM
phab-bot published this revision for review.Apr 17 2023, 9:39 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptApr 17 2023, 9:39 PM
boris updated this revision to Diff 711316.May 2 2023, 9:22 PM

Rebased

Harbormaster completed remote builds in B532815: Diff 711316.May 2 2023, 9:22 PM
boris updated this revision to Diff 711951.May 3 2023, 6:49 PM

Rebased

Harbormaster completed remote builds in B533317: Diff 711951.May 3 2023, 6:49 PM
boris added a reviewer: layout-reviewers.May 3 2023, 9:54 PM
emilio accepted this revision as: emilio.May 4 2023, 11:04 AM
emilio added a project: testing-approved.
emilio added inline comments.
servo/components/style/values/specified/animation.rs
210

Does Self not work? That's unfortunate.

This revision is now accepted and ready to land.May 4 2023, 11:04 AM
boris marked an inline comment as done.May 4 2023, 9:34 PM
boris added inline comments.
servo/components/style/values/specified/animation.rs
210

It's unfortunate that it doesn't work. :(
It treats Self as a keyword and ask me to use a valid enum invariant (syntax error).

boris marked an inline comment as done.May 4 2023, 9:34 PM
Closed by commit rMOZILLACENTRALdf49bdfbde87: Bug 1814444 - Part 2: Support self keyword for scroll(). r=emilio (authored by boris). · Explain WhyMay 4 2023, 9:41 PM
This revision was automatically updated to reflect the committed changes.
boris added a commit: rMOZILLACENTRALdf49bdfbde87: Bug 1814444 - Part 2: Support self keyword for scroll(). r=emilio.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
animation/
6 lines91%
Loading...
15 lines96%
Loading...
servo/
components/
style/
values/
specified/
4 lines76%
Loading...
testing/
web-platform/
meta/
scroll-animations/
css/
--
9 lines--
--

Diff 712528

View Options

dom/animation/ScrollTimeline.h

Loading...
View Options

dom/animation/ScrollTimeline.cpp

Loading...
View Options

servo/components/style/values/specified/animation.rs

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-timeline-computed.html.ini

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-timeline-parsing.html.ini

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-timeline-scroll-functional-notation.tentative.html.ini

Loading...
Privacy · Cookies · Legal