Page MenuHomePhabricator

Bug 1808410 - Part 1: Move animation-related values from box.rs/ui.rs to animation.rs.
ClosedPublic

Authored by boris on Mar 28 2023, 11:18 PM.
Referenced Files
Unknown Object (File)
Oct 12 2025, 11:12 PM
Unknown Object (File)
Oct 11 2025, 3:21 AM
Unknown Object (File)
Jan 21 2025, 2:09 AM
Unknown Object (File)
Jan 17 2025, 5:03 AM
Unknown Object (File)
Jan 15 2025, 5:10 AM
Unknown Object (File)
Jan 14 2025, 12:01 AM
Unknown Object (File)
Jan 12 2025, 11:43 AM
Unknown Object (File)
Jan 9 2025, 1:32 PM
Subscribers

Details

Summary

Although we store animation and transition style values in StyleUIReset and
define their properties in longhands/ui.mako.rs, but we may move them in
the future if this style struct becomes too large. So let's move the
definition of their values to an independent module, animation, so we
don't have to worry about this again.

This patch doesn't change any other things. Only move code.

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Fix clang-format warnings

May be worth while at it to have separate animations / transitions modules?

This revision is now accepted and ready to land.Apr 20 2023, 12:03 PM

May be worth while at it to have separate animations / transitions modules?

Yes. I decide to move them into animation module.

boris retitled this revision from Bug 1808410 - Part 1: Move animation-related values from box.rs to ui.rs. to Bug 1808410 - Part 1: Move animation-related values from box.rs/ui.rs to animation.rs..Apr 20 2023, 11:07 PM
boris edited the summary of this revision. (Show Details)