Page MenuHomePhabricator
Differential D170944

Bug 1818811 - Make -moz-box-layout: flex default, and clean-up CSS. r=Gijs
ClosedPublic
Actions

Authored by emilio on Feb 24 2023, 7:53 PM.
Tags
Referenced Files
Unknown Object (File)
Mar 8 2026, 2:27 AM
Unknown Object (File)
Oct 13 2025, 12:16 PM
Unknown Object (File)
Oct 11 2025, 11:37 AM
Unknown Object (File)
May 25 2025, 5:19 PM
Unknown Object (File)
Apr 13 2025, 6:45 PM
Unknown Object (File)
Apr 9 2025, 9:25 PM
Unknown Object (File)
Mar 30 2025, 4:20 PM
Unknown Object (File)
Jan 3 2025, 2:11 PM
View All 10 Files
Subscribers
mak
MattN
mixedpuppy
mstriemer
willdurand

Details

Reviewers
Gijs
dholbert
dao
Group Reviewers
extension-reviewers
Restricted Project
desktop-theme-reviewers
Commits
rMOZILLACENTRAL572bd7458430: Bug 1818811 - Make -moz-box-layout: flex default, and clean-up CSS. r=Gijs…
Bugzilla Bug ID
1818811
Summary

Now it's on by default everywhere, so all this is not needed. No behavior
change effectively since the xul.css bits being removed effectively achieve the
same.

Diff Detail

Event Timeline

emilio created this revision.Feb 24 2023, 7:53 PM
Herald added a project: secure-revision. · View Herald TranscriptFeb 24 2023, 7:53 PM
Harbormaster completed remote builds in B511242: Diff 685875.Feb 24 2023, 7:53 PM
phab-bot published this revision for review.Feb 24 2023, 7:53 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: extension-reviewers. · View Herald TranscriptFeb 24 2023, 7:53 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: desktop-theme-reviewers. · View Herald Transcript
Herald added subscribers: mak, mstriemer, mixedpuppy, MattN. · View Herald Transcript
emilio added a child revision: D170945: Bug 1818811 - Remove flexbox emulation talos tests. r=#perftest-reviewers.Feb 24 2023, 7:53 PM
emilio added a reviewer: dholbert.Feb 25 2023, 12:49 AM
dao accepted this revision.Feb 26 2023, 1:07 AM
emilio updated this revision to Diff 686095.Feb 26 2023, 2:13 AM
Harbormaster completed remote builds in B511419: Diff 686095.Feb 26 2023, 2:13 AM
emilio updated this revision to Diff 686163.Feb 26 2023, 11:06 PM
Harbormaster completed remote builds in B511533: Diff 686163.Feb 26 2023, 11:06 PM
emilio added a parent revision: D171013: Bug 1818927 - Don't use collapsed attribute to hide thumb. r=dholbert.Feb 26 2023, 11:08 PM
willdurand accepted this revision as: extension-reviewers.Feb 27 2023, 9:40 AM
willdurand added a subscriber: willdurand.

r+ for toolkit/mozapps/extensions/content/aboutaddons.css

Gijs accepted this revision.Feb 27 2023, 12:34 PM
Gijs added a project: testing-exception-ui (Only changes ui styling, images, or localized strings).

Thanks!

This revision is now accepted and ready to land.Feb 27 2023, 12:34 PM
Closed by commit rMOZILLACENTRAL572bd7458430: Bug 1818811 - Make -moz-box-layout: flex default, and clean-up CSS. r=Gijs… (authored by emilio). · Explain WhyFeb 27 2023, 12:46 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRAL572bd7458430: Bug 1818811 - Make -moz-box-layout: flex default, and clean-up CSS. r=Gijs….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
browser/
base/
content/
2 lines--
themes/
shared/
1 line--
preferences/
1 line--
1 line--
devtools/
client/
themes/
1 line--
layout/
reftests/
xul/
1 line--
1 line--
1 line--
style/
2 lines--
2 lines93%
Loading...
test/
chrome/
1 line--
modules/
libpref/
init/
7 lines--
servo/
components/
style/
gecko/
6 lines98%
Loading...
properties/
longhands/
2 lines--
toolkit/
components/
alerts/
4 lines--
content/
13 lines--
mozapps/
extensions/
content/
1 line--
themes/
osx/
mozapps/
downloads/
2 lines--
shared/
in-content/
1 line--
4 lines--
2 lines--
windows/
mozapps/
downloads/
2 lines--
widget/
1 line96%
Loading...
xpcom/
ds/
1 line--

Diff 686339

View Options

browser/base/content/aboutDialog.css

Loading...
View Options

browser/themes/shared/browser-shared.css

Loading...
View Options

browser/themes/shared/preferences/preferences.css

Loading...
View Options

browser/themes/shared/preferences/siteDataSettings.css

Loading...
View Options

devtools/client/themes/common.css

Loading...
View Options

layout/reftests/xul/accesskey-ref.xhtml

Loading...
View Options

layout/reftests/xul/accesskey.xhtml

Loading...
View Options

layout/reftests/xul/text-crop.xhtml

Loading...
View Options

layout/style/nsStyleConsts.h

Loading...
View Options

layout/style/nsStyleStruct.cpp

Loading...
View Options

layout/style/test/chrome/chrome-only-media-queries.js

Loading...
View Options

modules/libpref/init/StaticPrefList.yaml

Loading...
View Options

servo/components/style/gecko/media_features.rs

Loading...
View Options

servo/components/style/properties/longhands/inherited_box.mako.rs

Loading...
View Options

toolkit/components/alerts/alert.css

Loading...
View Options

toolkit/content/xul.css

Loading...
View Options

toolkit/mozapps/extensions/content/aboutaddons.css

Loading...
View Options

toolkit/themes/osx/mozapps/downloads/unknownContentType.css

Loading...
View Options

toolkit/themes/shared/in-content/common-shared.css

Loading...
View Options

toolkit/themes/shared/profileDowngrade.css

Loading...
View Options

toolkit/themes/shared/profileSelection.css

Loading...
View Options

toolkit/themes/windows/mozapps/downloads/unknownContentType.css

Loading...
View Options

widget/nsXPLookAndFeel.cpp

Loading...
View Options

xpcom/ds/StaticAtoms.py

Loading...
Privacy · Cookies · Legal