#8154 closed defect (bug) (maybelater)
Consider bumping pre-commit checker on plugins to PHP 8.x
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | high | |
| Component: | Plugin Directory | Keywords: | |
| Cc: |
Description
The last messages in #3791 (4 years ago) indicate that PHP Linting uses PHP 8.1 for the SVN pre-commit checks. PHP 8.1 is now EOL:
https://www.php.net/supported-versions.php
Can we update it so that it can lint newer and more robust PHP code? Say PHP 8.4?
Change History (4)
#2
follow-up:
↓ 4
@
6 weeks ago
- Resolution set to maybelater
- Status changed from new to closed
The version of PHP we lint with depends on what version we are actually running. Currently we're using 8.1.x on the WordPress.org instances. If we bump it up to PHP 8.4 at some time, then it will be on that.
#3
@
6 weeks ago
Just noting that the systems team has expressed interest in bumping to PHP 8.4 in the not-too-distant future.
#4
in reply to:
↑ 2
@
5 weeks ago
Replying to Otto42:
The version of PHP we lint with depends on what version we are actually running. Currently we're using 8.1.x on the WordPress.org instances. If we bump it up to PHP 8.4 at some time, then it will be on that.
Is there a chance this information could be mentioned somewhere, for example, in the Plugin Guidelines? This issue only surfaced during the CI/CD workflow.
Thank you. I also messages Slack #core-php (because I didn't see #plugins).
I'm keen to help! I have some experience in linting/CI. As someone who tried to push shiny new version of a plugin with PHP 8.4/5 syntax, I could capitalize my shock when the linter errored :)