Making WordPress.org

Opened 5 years ago

Last modified 5 months ago

#5449 reopened defect (bug)

Add a favicon to https://plugins.trac.wordpress.org/

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by:
Milestone: Priority: lowest
Component: Trac Keywords:
Cc:

Description

Requests to https://plugins.trac.wordpress.org/ by most browsers request a favicon. The lack of one causes an (expensive) 404.

Adding a generic WP favicon to https://plugins.trac.wordpress.org/favicon.ico would benefit performance.

Change History (6)

#1 @pkbhatt
5 months ago

Favicon is alreay present on the site so marking this ticket as closed

#2 @pkbhatt
5 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

#3 follow-up: @jonoaldersonwp
5 months ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

#4 in reply to: ↑ 3 @dd32
5 months ago

  • Keywords performance removed

Replying to jonoaldersonwp:

https://plugins.trac.wordpress.org/favicon.ico returns a 404 error.

I'm still inclined to close this though, as this specific path returning a 404 isn't a huge issue.

The trac pages specify multiple paths to a favicon, which take precedence over the fallback path, and at least with Chrome and Firefox, no longer triggers the 404 requests.

$ curl -is https://meta.trac.wordpress.org/ | grep \\.ico
          <link rel="icon" href="/chrome/common/trac.ico" type="image/x-icon" />
<link rel="icon" href="https://s.w.org/style/trac/common/trac.ico?v=67c19393add65fcabf9516a6475c2be5" sizes="32x32" />
<link rel="icon" href="https://s.w.org/style/trac/common/trac.ico?v=67c19393add65fcabf9516a6475c2be5" sizes="192x192" />

#5 follow-up: @jonoaldersonwp
5 months ago

That'll only help on URLs/responses which return an HTML template with the head(er). That won't apply to RSS feeds, data views, raw code views, etc.

#6 in reply to: ↑ 5 @dd32
5 months ago

Replying to jonoaldersonwp:

That won't apply to RSS feeds, data views, raw code views, etc.

Ah, fair enough.

I'm happy with those triggering a favicon request, extreme-micro-optimizations for rarely used paths are not worth resolving IMHO.

Note: See TracTickets for help on using tickets.