Changeset 14774

Timestamp:

03/28/2026 08:10:10 PM (12 hours ago)

Author:

obenland

Message:

Theme Directory: Fix PHP warnings in the blueprint permission check and save handler.

Follow-up to [14771]. When a nonexistent theme slug is requested, the
theme data doesn't have a slug property. The permission callback and
save handler were trying to use it before checking for an error response,
triggering warnings. Check for errors first, matching the pattern already
used in the preview and review handlers.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/rest-api/class-theme-preview.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/rest-api/class-theme-preview.php

@@ -55 +55 @@
             ),
             'permission_callback' => function( $request ) {
-                $theme_data    = wporg_themes_theme_information( $request['slug'] );
+                $theme_data = wporg_themes_theme_information( $request['slug'] );
+
+                if ( ! empty( $theme_data->error ) ) {
+                    return false;
+                }
+
                 $theme_package = new WPORG_Themes_Repo_Package( $theme_data->slug );
 
-                if ( ! empty( $theme_data->error ) || ! $theme_package->post_author ) {
+                if ( ! $theme_package->post_author ) {
                     return false;
                 }
@@ -117 +122 @@
      */
     function set_blueprint( $request ) {
-        $theme_data    = wporg_themes_theme_information( $request['slug'] );
-        $theme_package = new WPORG_Themes_Repo_Package( $theme_data->slug );
+        $theme_data = wporg_themes_theme_information( $request['slug'] );
 
         if ( ! empty( $theme_data->error ) ) {
             return new WP_Error( 'error', $theme_data->error );
         }
+
+        $theme_package = new WPORG_Themes_Repo_Package( $theme_data->slug );
 
         // Validate the blueprint, TODO expand upon this.