Uploaded image for project: 'Maven Shared Components'
  1. Maven Shared Components
  2. MSHARED-1290

PropertyUtils cycle detection results in false positives

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • maven-filtering-3.2.0, maven-filtering-3.3.0, maven-filtering-3.3.1
    • None
    • maven-filtering
    • None

    Description

      I upgraded the maven-assembly-plugin in one of my projects from 2.6 to 3.6.0 and found that PropertyUtils was logging many false positives about cycles between properties.

      The cycle detection (introduced for MSHARED-417) reports false positives when a variable occurs multiple times in a property, example:

      depends=p1 >= ${version}, p2 >= ${version}, p3 >= ${version}
      version=1.2.3 

      While writing a unit test to fix this, I also found that there are also cycle false positives whenever one of the property values is the same as a property name, example:

      test1=${test2}
      test2=${test3}
      test3=test2

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              wborn Wouter Born
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: