isahc icon indicating copy to clipboard operation
isahc copied to clipboard

Refactor TLS API

Open sagebind opened this issue 3 years ago • 1 comments

Refactor the API for SSL/TLS configuration. This accounts for the fact that the TLS engine can vary (as rustls is now an option) and corrects some confusing parts of the API that don't always make sense.

sagebind avatar Apr 21 '22 01:04 sagebind

Codecov Report

Base: 52.99% // Head: 52.42% // Decreases project coverage by -0.56% :warning:

Coverage data is based on head (c39f6f8) compared to base (096aff7). Patch coverage: 28.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   52.99%   52.42%   -0.57%     
==========================================
  Files          56       59       +3     
  Lines        5831     5951     +120     
==========================================
+ Hits         3090     3120      +30     
- Misses       2741     2831      +90     
Impacted Files Coverage Δ
src/auth.rs 76.66% <0.00%> (ø)
src/config/proxy.rs 100.00% <ø> (ø)
src/error.rs 44.68% <0.00%> (+0.18%) :arrow_up:
tests/tls.rs 0.00% <0.00%> (ø)
src/tls/identity.rs 11.53% <11.53%> (ø)
src/tls/roots.rs 22.53% <22.53%> (ø)
src/tls/mod.rs 35.92% <35.92%> (ø)
src/config/mod.rs 69.33% <45.45%> (-4.50%) :arrow_down:
src/config/request.rs 71.05% <50.00%> (-2.56%) :arrow_down:
src/lib.rs 17.83% <50.00%> (+0.45%) :arrow_up:
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 16 '22 03:07 codecov[bot]