rescript-react-native icon indicating copy to clipboard operation
rescript-react-native copied to clipboard
verified publisher icon rescript-react-native

Replace xxxParams & xxxWithParams with *Options

Open MoOx opened this issue 6 years ago • 3 comments

Following https://github.com/reason-react-native/reason-react-native/pull/577#issuecomment-524734546

MoOx avatar Aug 28 '19 08:08 MoOx

I'm copying my comment as the PR is already merged.

What if instead of withOptions we used withOptional (or withOptionals)? Then we could have optional parameters or configs without causing much confusion.

sgny avatar Aug 28 '19 11:08 sgny

You see a problem with xxxWithOptions & xxxOptions because they look too similar? If so I would go for xxxWithOptions & xxxMakeOptions

MoOx avatar Aug 30 '19 07:08 MoOx

Not that they are too similar, but most arguments are in the end options in a config. Most are required and rarely when we have optional arguments it might be clearer to label the additional function as WithOptional.

sgny avatar Aug 31 '19 13:08 sgny