mdns icon indicating copy to clipboard operation
mdns copied to clipboard

Make mdns responder case-insensitive

Open abrender opened this issue 1 year ago • 3 comments

From the RFC:

The simple rules for case-insensitivity in Unicast DNS [RFC1034] [RFC1035] also apply in Multicast DNS; that is to say, in name comparisons, the lowercase letters "a" to "z" (0x61 to 0x7A) match their uppercase equivalents "A" to "Z" (0x41 to 0x5A). Hence, if a querier issues a query for an address record with the name "myprinter.local.", then a responder having an address record with the name "MyPrinter.local." should issue a response. No other automatic equivalences should be assumed.

abrender avatar Mar 12 '25 01:03 abrender

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.75%. Comparing base (3140ee3) to head (670d0e3). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   62.77%   63.75%   +0.98%     
==========================================
  Files           1        1              
  Lines         916      916              
==========================================
+ Hits          575      584       +9     
+ Misses        263      255       -8     
+ Partials       78       77       -1     
Flag Coverage Δ
go 63.75% <100.00%> (+0.98%) :arrow_up:
wasm 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 12 '25 01:03 codecov[bot]

Ready for review :) Sorry for the noisy checks.

abrender avatar Mar 12 '25 02:03 abrender

@Sean-Der - thanks so much for your work on this project. Any objection or concerns with merging this PR?

(PS - The 2 tests that I've added both fail at master, but succeed with this PR).

All the best, Avi B

abrender avatar Mar 18 '25 15:03 abrender