phpmyadmin icon indicating copy to clipboard operation
phpmyadmin copied to clipboard

Fixed unintentional column deletion (#17353)

Open sidearrow opened this issue 3 years ago • 1 comments

Signed-off-by: sidearrow [email protected]

Description

  • Fixed to not execute previous click event of [OK] button in confirmation modal

Fixes #17353


Before submitting pull request, please review the following checklist:

  • [x] Make sure you have read our CONTRIBUTING.md document.
  • [x] Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • [x] Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • [x] Every commit has a descriptive commit message.
  • [x] Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • [x] Any new functionality is covered by tests.

sidearrow avatar Aug 07 '22 09:08 sidearrow

Codecov Report

Merging #17678 (3adafd9) into master (2d41333) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #17678   +/-   ##
=========================================
  Coverage     53.75%   53.75%           
  Complexity    16871    16871           
=========================================
  Files           616      616           
  Lines         60090    60090           
=========================================
  Hits          32302    32302           
  Misses        27788    27788           
Flag Coverage Δ
dbase-extension 53.66% <ø> (ø)
recode-extension 53.60% <ø> (-0.02%) :arrow_down:
unit-7.2-ubuntu-latest 53.59% <ø> (-0.04%) :arrow_down:
unit-7.3-ubuntu-latest 53.92% <ø> (ø)
unit-7.4-ubuntu-latest 53.92% <ø> (ø)
unit-8.0-ubuntu-latest 54.01% <ø> (+0.01%) :arrow_up:
unit-8.1-ubuntu-latest 53.87% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 07 '22 10:08 codecov[bot]

Thank you for your contribution @sidearrow !

williamdes avatar Nov 25 '22 20:11 williamdes