The first commit is unrelated; it's just something that was annoying me and I had to fix.

The main commit fixes bug that was uncovered by my previous PR. I don't know why the code didn't allow empty values previously, but I assume it was just bad design that I didn't notice while refactoring. Anyway, this code still looks like a mess, so I might create another PR to refactor it more.

Fixes: #17658 #17663

Should this target QA_5_2 ?

Codecov Report

Merging #17673 (06d58c9) into QA_5_2 (e2c7aa8) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             QA_5_2   #17673      +/-   ##
============================================
+ Coverage     49.44%   49.45%   +0.01%     
+ Complexity    16711    16710       -1     
============================================
  Files           602      602              
  Lines         59759    59758       -1     
============================================
+ Hits          29547    29554       +7     
+ Misses        30212    30204       -8     

Flag	Coverage Δ
dbase-extension	48.23% <100.00%> (-0.06%)	:arrow_down:
recode-extension	48.19% <100.00%> (-0.02%)	:arrow_down:
unit-7.2-ubuntu-latest	48.20% <100.00%> (+0.04%)	:arrow_up:
unit-7.3-ubuntu-latest	49.44% <100.00%> (-1.20%)	:arrow_down:
unit-7.4-ubuntu-latest	50.58% <100.00%> (+1.16%)	:arrow_up:
unit-8.0-ubuntu-latest	49.56% <100.00%> (+0.02%)	:arrow_up:
unit-8.1-ubuntu-latest	50.77% <100.00%> (+1.15%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libraries/classes/InsertEdit.php	87.53% <100.00%> (-0.02%)	:arrow_down:
libraries/classes/Sql.php	47.05% <100.00%> (ø)
libraries/classes/Charsets.php	78.00% <0.00%> (-8.00%)	:arrow_down:
...ries/classes/Plugins/Auth/AuthenticationConfig.php	70.14% <0.00%> (-5.98%)	:arrow_down:
libraries/classes/Gis/GisLineString.php	86.99% <0.00%> (-0.82%)	:arrow_down:
libraries/classes/Transformations.php	60.91% <0.00%> (-0.51%)	:arrow_down:
libraries/classes/Gis/GisPolygon.php	78.20% <0.00%> (-0.43%)	:arrow_down:
libraries/classes/Gis/GisMultiPolygon.php	78.45% <0.00%> (-0.41%)	:arrow_down:
libraries/classes/Plugins/Export/ExportOdt.php	88.97% <0.00%> (-0.26%)	:arrow_down:
libraries/classes/Config/Descriptions.php	85.19% <0.00%> (+0.40%)	:arrow_up:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

Should this target QA_5_2 ?

You are right. Thanks!

Yes, thanks for these.

Please don't merge yet. I finally figured out why the check was there. I will adjust it soon.

@williamdes @MauricioFauth Please re-review. I applied a different fixed and added more tests.