Filip Skokan

Results 62 issues of Filip Skokan

Assume the following ```js const asn = require('asn1.js') const Bar = asn.define('Bar', function () { this.octstr().contains().obj( this.key('bar').octstr() ) }) const Foo = asn.define('Foo', function () { this.seq().obj( this.key('foo').use(Bar) ) })...

This PR makes use of the recently [landed](https://github.com/nodejs/node/pull/36952) `base64url` encoding option in Node.js when available on the `encode` method. This one is [benchmarked](https://gist.github.com/panva/f09df60cfbcc3f94637714b207e2d074#gistcomment-3597872) to be significantly faster than the replace...

As per https://wicg.github.io/webcrypto-secure-curves and https://github.com/WICG/proposals/issues/46 Pending adoption of the draft or its inclusion in at least some of the Web API runtimes that are not Node.js.

As per https://wicg.github.io/webcrypto-secure-curves and https://github.com/WICG/proposals/issues/46 Pending adoption of the draft or its inclusion in at least some of the Web API runtimes that are not Node.js.

This PR updates the WPT runner in an attempt to fix the following issues: - if a test file has a single expected failure new regressions are not caught -...

test
needs-ci
review wanted

#43455 uncovered that the following WPT tests fail only on [ubuntu1804_sharedlibs_withoutintl_x64](https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/33181/) and [ubuntu1804_sharedlibs_withoutssl_x64](https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/33181/) The work in #43455 enabled WPT regressions to be caught in files with expected failures. These three...

console

I'm not expecting to land this PR as-is but i'm seeking feedback from @nodejs/crypto namely @tniessen and @jasnell on the end state which this currently reflects. Overall the question is...

crypto
lib / src
experimental
needs-ci
review wanted
webcrypto

This PR fixes WebCryptoAPI deriveBits validation error behaviour. Fixes 512 WPTs

wip
crypto
experimental
needs-ci
webcrypto

This PR fixes WebCryptoAPI EC namedCurve validation error behaviour. Fixes 36 WPTs

wip
crypto
experimental
needs-ci
webcrypto

This PR fixes WebCryptoAPI AES key length validation error behaviour. Fixes 672 WPTs

wip
crypto
experimental
needs-ci
webcrypto