limnoria-plugins icon indicating copy to clipboard operation
limnoria-plugins copied to clipboard

SpiffyTitles: Fix bad links

Open cottongin opened this issue 3 years ago • 7 comments

Some further refactoring likely needs to take place here; see something like this from base Limnoria's Web implementation

cottongin avatar Apr 21 '22 18:04 cottongin

using this since a few days and. . . well . .. it doesnt create any errors and everything works like before :D

fred0r avatar Apr 30 '22 13:04 fred0r

well .. . . it does create errors compared to the current version - testurl: https://www.bbc.com/news/world-europe-61327638

fred0r avatar May 05 '22 02:05 fred0r

thx - the bbc example-link now works again. maybe you could also take a look into the announcement of msn links? example url: https://www.msn.com/en-ca/entertainment/entertainmenttopstories/heard-takes-stand-accuses-depp-of-violent-sexual-assault/ar-AAWXiBH?li=AAggNb9 but these msn-links also dont work with the unmodified variant.

fred0r avatar May 05 '22 21:05 fred0r

https://www.reuters.com/article/us-health-coronavirus-romania-posters-idUSKBN22B1YV works on orig but not with your variant.

fred0r avatar May 10 '22 10:05 fred0r

Sorry to ignore this for so long. Looks good but I'm going to run some tests... Ok, so tests run and I have to agree with @fred0r here and say this branch breaks more results than it fixes (which doesn't seem to be any? though I agree bad link handling is slightly broken)... I'll poke around at the code and figure out why that is...

oddluck avatar Jun 13 '22 04:06 oddluck

if i remember correct this url worked with this pull request, but not with the default: https://www.amazon.de/DenTek-Zahnseide-Sticks-Complete-Clean-St%C3%BCck/dp/B07JDM9G65

fred0r avatar Jun 23 '22 11:06 fred0r

my last 2 comments now work - maybe by updated 'requirements'.

maybe you could also take a look into the announcement of msn links? example url: https://www.msn.com/en-ca/entertainment/entertainmenttopstories/heard-takes-stand-accuses-depp-of-violent-sexual-assault/ar-AAWXiBH?li=AAggNb9

-> no announcement

fred0r avatar Jun 26 '22 18:06 fred0r