Mac Angell comments

Results 8 comments of


                                            Mac Angell

Consider migrating to pandastrike/jsck

Funny you mention this because I was just looking at that very blog post earlier this week and was considering the same thing.

Consider migrating to pandastrike/jsck

maybe there is a faster one yet: https://github.com/Muscula/json-schema-benchmark

Consistency with route configurations

Great question. [This issue](https://github.com/hapijs/hapi/issues/1039) may give you some context. At the time I built this module, they didn't allow other implementations to be used within the validate config. With that...

Consistency with route configurations

I was going to create a new one, but I'll actually just leave this one open for some additional context

Different identifier for increment and timing

Thanks for the contribution! A couple of questions: 1. What tool are you using to visualize the metrics? From my experience, Graphite and Grafana are able to differentiate these metrics...

Different identifier for increment and timing

you could do something as simple as a boolean like `includeMetricTypeInName` as an option, and if it's true, add it like you are doing now.

return a Promise

Thanks for the PR! I don't think it's necessary to support older versions of Node. I'll take a look at this tonight.

Concatenating files can generate same hash?

That's true, thanks for uncovering this issue. I'll get this fixed soon.