timesketch icon indicating copy to clipboard operation
timesketch copied to clipboard

Fixed an issue with too long lines in JSON ingestion

Open lprat opened this issue 4 years ago • 4 comments

fix issue #1754

lprat avatar Apr 30 '21 08:04 lprat

Hi @lprat What is the status of this PR?

berggren avatar Jul 01 '21 07:07 berggren

Hi, I waiting for validation. But maybe @kiddinn has fix it?

Thanks.

lprat avatar Jul 01 '21 11:07 lprat

@lprat could you check this PR? It is outstanding for quite a while with open conversations and conflicts that make it impossible to merge, could you please have a look?

Thx a lot

jaegeral avatar Nov 25 '21 12:11 jaegeral

@jaegeral sorry for the old PR. I changed fix to simply log error when line json is too long.

lprat avatar Nov 25 '21 16:11 lprat

Looks like we have not merged that in over a year and as far as I can tell, we have not seen any issues from other people, so I am going to close this out, thx lprat still for the contribution, if one would run in the issue again we can re-visit the PR.

jaegeral avatar Nov 18 '22 09:11 jaegeral