fix: ensure chrome colors are initialized
Fixes #34406
After https://chromium-review.googlesource.com/c/chromium/src/+/3526815 we need to initialize chromes colors if we want to support pip.
Notes: Picture-In-Picture mode no longer becomes a red rectangle on hover
The missing definition looks being defined here: https://github.com/electron/electron/blob/main/shell/browser/ui/views/win_frame_view.cc https://github.com/electron/electron/blob/main/shell/browser/ui/views/win_frame_view.h
Thanks @MarshallOfSound!
Thank you @MarshallOfSound!
I think we need to add chrome/browser/ui/color/win/native_chrome_color_mixer_win.cc to chromium_src/BUILD.gn
@MarshallOfSound, sorry for the ping, could you apply the suggestions we wrote, if you have your hands full of work I can try to do a similar PR trying to address this problem (I know nothing C++ code but I can follow your code and use the suggestions here) just let me know.
Release Notes Persisted
Picture-In-Picture mode no longer becomes a red rectangle on hover
I have automatically backported this PR to "19-x-y", please check out #35400
I have automatically backported this PR to "21-x-y", please check out #35401
I have automatically backported this PR to "20-x-y", please check out #35402
/trop run backport-to 18-x-y
@arnaudbud is not authorized to run PR backports.
@arnaudbud I have tested 18.x it there is no such issue