electron icon indicating copy to clipboard operation
electron copied to clipboard

fix: ensure chrome colors are initialized

Open MarshallOfSound opened this issue 3 years ago • 4 comments

Fixes #34406

After https://chromium-review.googlesource.com/c/chromium/src/+/3526815 we need to initialize chromes colors if we want to support pip.

Notes: Picture-In-Picture mode no longer becomes a red rectangle on hover

MarshallOfSound avatar Jul 23 '22 00:07 MarshallOfSound

The missing definition looks being defined here: https://github.com/electron/electron/blob/main/shell/browser/ui/views/win_frame_view.cc https://github.com/electron/electron/blob/main/shell/browser/ui/views/win_frame_view.h

leonardxfce-dialpad avatar Jul 25 '22 15:07 leonardxfce-dialpad

Thanks @MarshallOfSound!

ShukantPal avatar Jul 30 '22 19:07 ShukantPal

Thank you @MarshallOfSound!

h615861768 avatar Aug 01 '22 05:08 h615861768

I think we need to add chrome/browser/ui/color/win/native_chrome_color_mixer_win.cc to chromium_src/BUILD.gn

codebytere avatar Aug 01 '22 10:08 codebytere

@MarshallOfSound, sorry for the ping, could you apply the suggestions we wrote, if you have your hands full of work I can try to do a similar PR trying to address this problem (I know nothing C++ code but I can follow your code and use the suggestions here) just let me know.

leonardxfce-dialpad avatar Aug 10 '22 13:08 leonardxfce-dialpad

Release Notes Persisted

Picture-In-Picture mode no longer becomes a red rectangle on hover

release-clerk[bot] avatar Aug 22 '22 14:08 release-clerk[bot]

I have automatically backported this PR to "19-x-y", please check out #35400

trop[bot] avatar Aug 22 '22 14:08 trop[bot]

I have automatically backported this PR to "21-x-y", please check out #35401

trop[bot] avatar Aug 22 '22 14:08 trop[bot]

I have automatically backported this PR to "20-x-y", please check out #35402

trop[bot] avatar Aug 22 '22 14:08 trop[bot]

/trop run backport-to 18-x-y

arnaudbud avatar Aug 22 '22 19:08 arnaudbud

@arnaudbud is not authorized to run PR backports.

trop[bot] avatar Aug 22 '22 19:08 trop[bot]

@arnaudbud I have tested 18.x it there is no such issue

PikachuEXE avatar Aug 23 '22 00:08 PikachuEXE