coder icon indicating copy to clipboard operation
coder copied to clipboard

Move template schedule controls into enterprise

Open ammario opened this issue 3 years ago • 2 comments

As a big-deployment administrative feature, schedule controls should be in our enterprise version.

The specific flags are:

  • --max_ttl
  • and --min_autostart_interval

ammario avatar Jul 29 '22 19:07 ammario

huge agree

tjcran avatar Jul 29 '22 19:07 tjcran

I had an issue for this already and @ammario closed it not planned. Thanks.

sharkymark avatar Jul 30 '22 17:07 sharkymark

@spikecurtis @presleyp if we need a smaller test target for licensing that may be finished before Audit Logging, this is a good candidate.

tjcran avatar Aug 12 '22 19:08 tjcran

Need some additional information here about how this will behave as part of a licensed feature: does it show up as a toggle on the licensing page? etc.

misskniss avatar Aug 16 '22 15:08 misskniss

We will hold on this until after we bring in audit logging.

misskniss avatar Aug 16 '22 15:08 misskniss

Need some additional information here about how this will behave as part of a licensed feature: does it show up as a toggle on the licensing page? etc.

This should appear as a toggle on the Template page, and anyone with edit access to the template may edit the schedule controls.

ammario avatar Aug 16 '22 16:08 ammario

Need some additional information here about how this will behave as part of a licensed feature: does it show up as a toggle on the licensing page? etc.

This should appear as a toggle on the Template page, and anyone with edit access to the template may edit the schedule controls.

I think the question was asking on how the feature should be enabled/disabled. e.g. Audit Logging will have an admin toggle to enable/disable audit logging as a feature.

I don't think that is necessary for this feature... and the feature itself could have controls on the template page as Ammar suggested.

tjcran avatar Aug 16 '22 16:08 tjcran

Yeah, I don't see the value in a global toggle for either feature.

ammario avatar Aug 16 '22 16:08 ammario