RPC tests:

• Fix help help
• help tests
• remove getinfo.
• test for getblockchaininfo.
• test for getnetworkinfo.
• Change verifytxoutproof to check totalTX count if possible. (performance degrades)
  • If performance is an issue we could index this information separately or with headers(entry).
• Add tests for gettxoutproof and verifytxoutproof.

Codecov Report

Merging #810 into master will increase coverage by 4.76%. The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   62.01%   66.78%   +4.76%     
==========================================
  Files         147      147              
  Lines       25379    25384       +5     
==========================================
+ Hits        15740    16953    +1213     
+ Misses       9639     8431    -1208

Impacted Files	Coverage Δ
lib/node/rpc.js	33.16% <93.33%> (+6.31%)	:arrow_up:
lib/primitives/mtx.js	61.56% <0%> (+0.12%)	:arrow_up:
lib/wallet/walletdb.js	77.7% <0%> (+0.25%)	:arrow_up:
lib/mempool/mempool.js	65.76% <0%> (+0.33%)	:arrow_up:
lib/coins/coinview.js	75.17% <0%> (+0.7%)	:arrow_up:
lib/net/bip152.js	86.1% <0%> (+1.01%)	:arrow_up:
lib/primitives/abstractblock.js	89.88% <0%> (+1.12%)	:arrow_up:
lib/node/node.js	76.25% <0%> (+1.43%)	:arrow_up:
lib/net/packets.js	80% <0%> (+2.04%)	:arrow_up:
lib/primitives/block.js	75.1% <0%> (+2.4%)	:arrow_up:
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4542ec5...828a269. Read the comment docs.

Probably worth adding tests for getblockchaininfo and other info related methods getnetworkinfo and getmininginfo that were added as replacement in addition to getinfo. As far as deprecating getinfo, it would probably be good to do, since it's mostly stubbed out currently.

I can do those test in this PR as well, I was considering doing it in separate PR. At least deprecation can happen here