Add `asBoolean|Byte|Short|Int|Long|Float|Double` to `String` assertions
As #2509 (comment) mentioned, several methods are added as the shortcuts for extracting boolean and numbers.
Check List:
- Closes #2520
- Unit tests : YES
- Javadoc with a code example (on API only) : YES
- PR meets the contributing guidelines
Hi @scordio, sorry for bothering. This PR implements the methods you mentioned, could you please review the code?
Hi @HeZean, thanks for the PR.
Despite my proposal at https://github.com/assertj/assertj-core/issues/2509#issuecomment-1057395093, we haven't discussed these new methods in the team yet, so it may take some time before we move on to the review phase.
Thanks in advance for your patience!
Hi @scordio, it seems that 3.24.2 is already released. Any update on the methods related in this pr?
Tentatively slated for 3.24.0 solely for the purpose of team discussion in https://github.com/assertj/assertj/issues/2520#issuecomment-1105367372
Hi @hezean , thanks again for your patience. I'll make sure this gets covered for 3.25.0.
Hi @joel-costigliola, I really appreciate for your review, and thanks for giving me an opportunity to contribute to assertj!
I've just cleaned up this PR, fixing all the issues you pointed out. Please let me know if anything should be made better.
Integrated thanks @hezean! I did some minor cleanup and added support for soft assertions which is a bit tricky to do if you are not familiar with how they work, you can look at the commit if you are interested, anyway you get full credit for the changes :wink: