aiogram_album_handler icon indicating copy to clipboard operation
aiogram_album_handler copied to clipboard

Migrate to aiogram repo? :)

Open Olegt0rr opened this issue 4 years ago • 4 comments

I suggest you to add this code as a PR to aiogram repo. It will help more people there.

Olegt0rr avatar Aug 15 '21 19:08 Olegt0rr

The current implementation is flawed as this middleware doesn't work with fast=False polling and webhooks. Thus, I don't think it would be appropriate to add this to the aiogram GitHub repo until I, or someone else, have time to make certain adjustments to this middleware. Also, afaik, there is a better decision for catching media group out there written by someone else, although that one is a lot more complex than mine.

WhiteMemory99 avatar Aug 15 '21 19:08 WhiteMemory99

I use similar solution with 1 sec latency and "typing..." - works good for me.

Could you share a link to "better solution" you mentioned above?

Olegt0rr avatar Aug 15 '21 19:08 Olegt0rr

I believe, this one is more refined in terms of its reliability.

WhiteMemory99 avatar Aug 15 '21 19:08 WhiteMemory99

I believe, this one is more refined in terms of its reliability.

This code is not suitable for high loads, too many redundant actions and calls

Olegt0rr avatar Aug 16 '21 05:08 Olegt0rr