cargo-sort icon indicating copy to clipboard operation
cargo-sort copied to clipboard

Feature request: publish Docker images

Open orhun opened this issue 3 years ago • 5 comments

Proposal

It would be nice to have a Dockerfile in the repository + workflow to automatically publish Docker images to Docker Hub.

This could be beneficial in a couple of ways:

  1. Containerization.
  2. A dedicated GitHub action could be created. (*)
  3. Docker image could be utilized in GitLab CI.

I would like to work on a minimal Dockerfile if this is applicable.

orhun avatar May 28 '22 16:05 orhun

So sorry that I took so long to respond. I would totally be open to a PR to do this otherwise I don't have the skills to implement this on my own (no docker experience).

DevinR528 avatar Jun 12 '22 22:06 DevinR528

As the first step, I added the Dockerfile in #42

For the next step (publishing), I need some details from you:

  • where should the images be published? (Docker Hub, GHCR)
  • can you create an account on the registries and let me know your username? (especially Docker Hub)

If you can help me with those I would like to submit another PR for adding the Docker build workflow. 🐻

orhun avatar Jul 12 '22 11:07 orhun

Do you have a suggestion as to which would be better? I can make an account on whichever and send it to you!

DevinR528 avatar Jul 17 '22 20:07 DevinR528

Do you have a suggestion as to which would be better? I can make an account on whichever and send it to you!

Docker Hub would be nice! Just create an account there and tell me your username. You also need to add a secret to the repository (DOCKERHUB_TOKEN) but I will let you know about that in the PR.

orhun avatar Jul 17 '22 20:07 orhun

I had one, my username is devinr528.

DevinR528 avatar Jul 23 '22 21:07 DevinR528