Skip to content

Add Reviewer Roulette via CI/CD component danger-review

Peter Leitzen requested to merge pl-danger-review into main

Why is this change being made?

This MR adds Reviewer Roulette (provided by https://gitlab.com/gitlab-org/components/danger-review/-/tree/main?ref_type=heads and https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/) to make available reviewers more visible to MR authors.

Currently, one can use Reviewers in the sidebar or Approvers in the MR widget but they are either imprecise or don't have a roulette functionality.

Note In order to make Danger post message to MRs we need to setup a project token (api scope with Developer role) and a CI/CD variable called DANGER_GITLAB_API_TOKEN to contain this project token (Masked but not Protected).

See https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/#ci-configuration

Screenshots

README.md
Screenshot_from_2024-03-27_12-52-50

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Division: If the update affects your division, share the MR in your division Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Add Reviewer Roulette via CI/CD component danger-review
Edited by Peter Leitzen

Merge request reports