Skip to content

Added Ms Sql Server timestamp support.#45

Merged
JonathanMagnan merged 1 commit intozzzprojects:masterfrom
AntonD-W:master
Mar 2, 2021
Merged

Added Ms Sql Server timestamp support.#45
JonathanMagnan merged 1 commit intozzzprojects:masterfrom
AntonD-W:master

Conversation

@AntonD-W
Copy link

No description provided.

@JonathanMagnan JonathanMagnan self-assigned this Feb 24, 2021
@JonathanMagnan
Copy link
Member

Thank you for your pull,

One of my developers will review it this week.

Best Regards,

Jon


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

{
public static bool UseDefaultForNotNullable { get; set; }

public static bool UseSqlServerTimestamp { get; set; }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this should be done as a separate setting, or maybe just add a reverse? I don't know any databases other than SqlServer that use this format.
If there are no such databases, then the point of setting is only to support backward compatibility. But even in this case, there will be support for the wrong format.

@JonathanMagnan
Copy link
Member

Hello @AntonD-W ,

The method GetLastTimestamp makes sense.

However, indeed, as you commented, I believe added a static bool such as ReverseByte would be a better idea than specifying a provider.

I will merge your pull and make the change. It should be released later tonight or tomorrow.

Best Regards,

Jon

@JonathanMagnan JonathanMagnan merged commit 381af9b into zzzprojects:master Mar 2, 2021
@AntonD-W
Copy link
Author

AntonD-W commented Mar 2, 2021

Thank you @JonathanMagnan

@JonathanMagnan
Copy link
Member

Hello @AntonD-W ,

The v3.1.2 has been released.

Honestly, I didn't know how to name this options so well, don't judge the name: UseTimestampBytesReverse. If you have a better one, I believe it's time to change it since you are the only one that will use it for now.

Let me know if everything works as you wish.

Best Regards,

Jon

@AntonD-W
Copy link
Author

AntonD-W commented Mar 3, 2021

Hello @JonathanMagnan

Normal name UseTimestampBytesReverse. We have updated the packages, everything is working as it should. Thank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants