Fix AOT warning with HtmlNode.GetAttributeValue#573
Merged
JonathanMagnan merged 2 commits intozzzprojects:masterfrom Nov 11, 2024
Merged
Fix AOT warning with HtmlNode.GetAttributeValue#573JonathanMagnan merged 2 commits intozzzprojects:masterfrom
JonathanMagnan merged 2 commits intozzzprojects:masterfrom
Conversation
Closed
Contributor
Author
|
@JonathanMagnan Do you think we can proceed with this PR? I'm just trying to figure out my options :) |
Member
|
Hello @euju-ms , Sorry, I forgot to answer. I'm currently on vacation this week in Mexico. So, I will look at it next week when I will be back. Best Regards, Jon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T HtmlNode.GetAttributeValue<T>(string name, T def)is not AOT compatible because it calls into an extension methodUtilities.To(which is also not AOT compatible).This PR makes
T HtmlNode.GetAttributeValue<T>(string name, T def)obsolete, and adds an overload for GetAttributeValue that takes in an additional parameterparserfor converting the string attribute value into type T.All the internal usages are converted to use the new API.