Reduce need to call string.ToLower with proper comparisons#559
Merged
JonathanMagnan merged 1 commit intozzzprojects:masterfrom Sep 17, 2025
Merged
Reduce need to call string.ToLower with proper comparisons#559JonathanMagnan merged 1 commit intozzzprojects:masterfrom
JonathanMagnan merged 1 commit intozzzprojects:masterfrom
Conversation
* mark methods static
lahma
force-pushed
the
replace-to-lower
branch
from
4bd8641 to
70be67f
Compare
Member
|
Hello @lahma , Thank you for your contribution ;) I'm not 100% sure about marking the method static is a good idea or not for an existing method, but let go ahead with this change. Best Regards, Jon |
Contributor
Author
No worries, thank you for accepting them 👍🏻
For private and internal methods it should affect the public API or expectations. .NET API analyzers flags such methods that they should be static so it will help the compiler and runtime to optimize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.