Optimize HtmlNode.WriteAttribute#556
Merged
JonathanMagnan merged 1 commit intozzzprojects:masterfrom Sep 15, 2025
Merged
Conversation
lahma
force-pushed
the
write-stream-without-concatenation
branch
from
aa058eb to
c4dee93
Compare
|
I literally came here to write a PR that does this!!! After tracing my app and finding that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking for docfx performance, I noticed that a lot of string allocations were done inside of HtmlAgilityPack. This PR changes
WriteAttributeto call separate Write calls instead of concatenating strings before writing them.