Optimize removal of filter disabled conditions#163
Merged
JonathanMagnan merged 3 commits intozzzprojects:masterfrom Nov 3, 2019
Merged
Optimize removal of filter disabled conditions#163JonathanMagnan merged 3 commits intozzzprojects:masterfrom
JonathanMagnan merged 3 commits intozzzprojects:masterfrom
Conversation
Can use OrdinalIgnoreCase since parameters are of well-known format with no unusual characters
CommandText was originally updated on each iteration, but optimization caused it only to update on complete success. Now, if parse error occur after some successful replaces we bail out and set the CommandText as earlier.
Member
|
Thank you @TobiasMarklund for your pull, we will try to review it during the weekend and release it if accepted. Best Regards, Jonathan Performance Libraries Runtime Evaluation |
Member
|
Hello @TobiasMarklund , Thank you for your contribution. The v3.1.1 has been released. It includes your both pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling our db code, we saw a hotspot in the '''RemoveFilterDisabledConditionFromQuery''' method. There are a few optimizations able to be made here:
Benchmarks on EF-generated command strings from our product yields somewhere between 10-100x time improvement for this method over original code. Memory allocations may cause few KB more allocations on very small queries, but saves several megabytes on large queries with many replacements.