refactor: eliminate duplicate shell script and templates via symlinks#15
Merged
Conversation
src/wtcraft/_shell.sh → ../../scripts/wtcraft src/wtcraft/templates → ../../templates Eliminates the maintained-in-two-places copies. setuptools follows symlinks when collecting package-data so pyproject.toml is unchanged. _cli.py's os.path.isfile/isdir calls resolve symlinks transparently. https://claude.ai/code/session_01PMQRznX4uyUZLJ7PR1kPax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/wtcraft/_shell.sh→ replaced with symlink../../scripts/wtcraftsrc/wtcraft/templates/→ replaced with symlink../../templatesWhy no other files changed
pyproject.toml— setuptools follows symlinks when collectingpackage-data, so the existing entries bundle the real file contents unchangedsrc/wtcraft/_cli.py—os.path.isfile/os.path.isdirresolve symlinks transparently;os.path.realpath()on lines 25-26 already normalises the pathMANIFEST.in— unaffectedtests/smoke.sh— referencesscripts/wtcraftdirectly, unaffectedTest plan
diff src/wtcraft/_shell.sh scripts/wtcraft— no diff (files were identical before replacement)diff -r src/wtcraft/templates templates— no diffos.path.isfile(shell_path)andos.path.isdir(tmpl_dir)both returnTruethrough symlinksreadlink -fconfirms symlinks resolve to canonical repo pathspip install -e . && wtcraft --help— verify installed entry point worksbash tests/smoke.sh— full smoke testhttps://claude.ai/code/session_01PMQRznX4uyUZLJ7PR1kPax
Generated by Claude Code