Repository navigation
refactor(tui): remove the unused half of pi-test-support (plan D.5) - #63
Merged
zy1233 merged 2 commits intoOct 31, 2026
Merged
Conversation
`pi-test-support` had seven modules that no test of the workspace refers to: `mock_server` (an inference server), `inference_override`, `scripted` and `sse` (what that server answers with), `acp_client` (two ACP stdio clients), `headless` (a runner for `-p`) and `counting_server`. That is 5,443 lines and 47 test functions. They were for the tests of the Rust agent runtime, and that runtime is gone (plan phase D.8). The workspace builds with its tests without them, so nothing uses them. - `env.rs`: `grok_binary` (it finds or builds the pager binary for the removed clients) and `git_workdir` go. Only the removed modules called the first, and nothing called the second. `EnvGuard` and `env_parse` stay. - `lib.rs`: the re-exports of the removed modules go. `scaled`, `EnvGuard`, `TestSandbox`, `TestProcess` and `ResourceSnapshot` with its sampler stay: tests of `pi-shell`, `pi-pager` and `pi-tools` use them. - `Cargo.toml`: eleven dependencies go (`agent-client-protocol`, `anyhow`, `async-trait`, `axum`, `futures-util`, `pi-acp-lib`, `serde`, `serde_json`, `tokio-util`, `tracing`, and `reqwest`, a dev-dependency). `tui/Cargo.lock` loses 11 lines and no package. - `README.md` is written again. The old one had 90 lines about the removed modules. The crate is a dev-dependency of `pi-shell`, `pi-pager` and `pi-tools`, so `zypi` does not change. The suites have the numbers of before: `pi-shell` 838, `pi-pager` 5,651.
An entry under Removed for the commit above: what goes, what stays, and the numbers.
zy1233
force-pushed
the
refactor/tui-trim-test-support
branch
from
October 31, 2026 02:51
adc3664 to
f457906
Compare
This was referenced Oct 31, 2026
Owner
Author
|
Stack #66, bottom to top: #58, #59, #56, #57, #60, #61, #62, #63, #64, #65. One atomic squash merge ( Position 8 of 10. Base: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plan phase D.5.
pi-test-supporthas seven modules that no test refers to. They are the mock inference server, the SSE builders, the ACP stdio clients, the headless runner and the counting server: test kit of the Rust agent runtime, which is gone. The workspace builds with its tests without them. They go, with the two helpers that only they called, and with the dependencies that only they needed.Two commits: the code, then the
CHANGELOG.mdentry.pi-test-supportis a dev-dependency ofpi-shell,pi-pagerandpi-tools(publish = false).Evidence
mock_server, 13 insse, 3 inheadless).pi-shell838 passed andpi-pager5,651 passed, 12 skipped (the references of the manifest).After:
tui_baseline.py test(Linux, WSL2, nextest):pi-shell838 passed, 0 failed, 1 skipped.pi-pager5,651 passed, 0 failed, 12 skipped (includespython_agent_e2e). The 23 tests that remain inpi-test-support: 23 passed.tui_baseline.py checkon the branch: warnings 0, consumer build exit 0,cargo check --workspace --tests --lockedexit 0, graph 970 packages (ceiling 970), residueleader243/243 andx.ai297/297 (unchanged: the ceilings stay).tokio-utilhad the featurecompatfrom this crate.cargo check --locked -p pi-tools --tests, and the suite builds ofpi-shellandpi-pager, all pass.tui_notices.py check: 984 packages ship, 984 entries, 0 missing, 0 stale.Cargo.lockloses 11 lines and no package.CHANGELOG.mdconflicts) has the sametui/Cargo.lockas cargo writes by itself (equal file hash), andtui_baseline.py checkon it is all green: warnings 0, graph 970,leader239/239,x.ai282/282,cargo check --workspace --tests --lockedexit 0.ruff check .andruff format --check .pass. No Python file changes.Merge Danger
Door: two-way. One revert brings the files back.
Blast Radius: tests only. No crate that ships depends on
pi-test-support, sozypidoes not change.CHANGELOG.mdconflicts with #60, #61 and #62: all add a section under[Unreleased]. Keep all of them. There is no other conflict. This PR and #62 both changetui/Cargo.lock, in different places. The result of both merged is the lock that cargo writes by itself (same file hash), so the order does not matter.