Repository navigation
fix(tui): the /resume picker lists sessions that are more than 30 days old - #61
Merged
zy1233 merged 1 commit intoOct 31, 2026
Conversation
This was referenced Oct 30, 2026
…s old parse_session_picker_entries dropped every session whose updatedAt was more than 30 days old. The rule came from the upstream project. With the Python agent it hid a session that nobody touched for a month: gone from /resume, while --resume <id> still opened it (plan decision 9; its tendency was to remove the cutoff, because the agent pages the list). The cutoff is gone. The picker shows every row that the agent lists (50 for a page, up to 100 pages). A row whose updatedAt does not parse is still left out, as before. Tests: picker_drops_old_conversation_past_cutoff_in_standard_acp_mode (it asserted the drop, with a message that said the opposite) becomes picker_keeps_a_session_older_than_30_days, and a new test passes a standard ACP session/list page with an old, an older and a new session through session_picker_entries_from_acp. pi-pager: +1 net (5,657). CHANGELOG.md: one entry under Fixed.
zy1233
force-pushed
the
fix/tui-resume-picker-age-limit
branch
from
October 31, 2026 02:51
69d6ef4 to
de053f2
Compare
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plan decision 9.
/resumeleft out every session that was last updated more than 30 days ago. The rule came from the upstream project. With the Python agent, a session that nobody touched for a month was gone from the picker, and only--resume <id>could still open it. The cutoff is removed. This is the tendency written in the plan: the agent pages the list, so a longer list is not a problem.parse_session_picker_entries(payload) for each row of payload.sessions skip a row with no usable first prompt or summary - skip a row whose updatedAt is older than now - 30 days skip a row whose updatedAt does not parse # unchangedStacked on #60. The base of this PR is
fix/tui-dead-settings-and-flags, because both PRs changeCHANGELOG.mdandscripts/tui_baseline.tomlat the same lines. Merge #60 first. Then change the base of this PR tomainif GitHub does not do it.Evidence
picker_drops_old_conversation_past_cutoff_in_standard_acp_modepasses and asserts the drop: one row withupdatedAt = 2020-01-01gives an empty list. (Its failure message said the opposite.)After: two tests take its place. They assert what the old code dropped:
pi-pagersuite (scripts/tui_baseline.py test, nextest, Linux, WSL2): 5,657 passed, 0 failed, 12 skipped. Before: 5,656 (one test gone, two new).scripts/tui_baseline.tomlgoes up by the same one.CHANGELOG.md: one entry under### Fixed.ruff check .andruff format --check .pass on Windows. No Python file changes.Merge Danger
Door: two-way. One revert brings the cutoff back.
Blast Radius: the list of the
/resumepicker. It can show more rows: a user with sessions from earlier months now sees them. The picker still reads up to 100 pages of 50 rows, and it still waits for all pages before it draws (about 0.8 s for 1,000 sessions on Windows; plan decision 11 is the open item that would draw while the pages arrive).--resume <id>, the agent, the session files and every other picker do not change. A row with noupdatedAtthat parses is still left out.