compat with ReScript v10#372
Merged
Merged
Conversation
This was referenced Jul 7, 2022
29 tasks
This was referenced Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373
The issue was that the ReScript v10 parser inserts (internal) attributes at positions that
ppxlibdoes not consider valid OCaml.Solution short/mid term: use forked
ppxlibthat has been patched to ignore the invalid attributes.Solution long term: Move off of
ppxlib(and other OCaml-specific libraries completely where ReScript might break compat).ppxlibwith the fix applied: https://github.com/zth/ppxlib/tree/rescript-attrs