Remove duplicate integration test data entry#999
Merged
christopher-henderson merged 2 commits intozmap:masterfrom Oct 25, 2025
Merged
Remove duplicate integration test data entry#999christopher-henderson merged 2 commits intozmap:masterfrom
christopher-henderson merged 2 commits intozmap:masterfrom
Conversation
christopher-henderson
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
When setting this up on a new computer, I noticed that the integration tests were running on 80 files, but only downloading 79 files. Looking back at the history, I think this entry got inadvertently duplicated in #738 when a second batch of certificates were added to the test corpus. I don't believe there's any benefit to running the test over the same file twice, so this change removes the extra file and decrements the failure counters.
I'm not sure if this means that a file was missed that was supposed be included. I looked at the corpus repo, and there are actually a bunch of files that have never been included in the test. I have no context why these files were excluded, so I kept this change minimal.
Testing