Allowed subjectdn attributes#992
Merged
christopher-henderson merged 50 commits intozmap:masterfrom Sep 27, 2025
Merged
Conversation
christopher-henderson
approved these changes
Sep 27, 2025
Member
christopher-henderson
left a comment
christopher-henderson
left a comment
There was a problem hiding this comment.
Thank you @mtgag and Deutsche Telekom Security for the clean and reasonable lint!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deutsche Telekom Security brought to my attention an issue with e_subject_country_name, suggested providing a fix, and also sponsored the development. The lint currently checks the value of countryName only for mailbox-validated certificates, whereas it should be checked for all other S/MIME certificates except these. For mailbox-validated certificates, the country attribute must not be present. This PR fixes the issue by ensuring the check is applied to the other certificate types and adds a new lint to verify the presence of certain attributes in mailbox-validated certificates.