Skip to content

Replace CRL Distribution Points oid(2.5.29.31) with Issuing Distribution Point oid(2.5.29.28) when checking crl extension validity#974

Merged
christopher-henderson merged 3 commits intozmap:masterfrom
whtung:master
Jul 27, 2025
Merged

Conversation

@whtung
Copy link
Copy Markdown
Contributor

@whtung whtung commented Jul 14, 2025 •
edited
Loading

@kowshikRoy

Hi Repon,

May I have this change?
Replace CRL Distribution Points oid(2.5.29.31) with Issuing Distribution Point oid(2.5.29.28) when checking crl extension validity

@whtung
Replace CRL Distribution Points oid(2.5.29.31) with Issuing Distribut…
04ea8e9 
…ion Point oid(2.5.29.28) when checking crl extension validity
@whtung whtung changed the title Replace CRL Distribution Points oid(2.5.29.31) with Issuing Distribut… Replace CRL Distribution Points oid(2.5.29.31) with Issuing Distribution Point oid(2.5.29.28) when checking crl extension validity Jul 14, 2025
@kowshikRoy
Copy link
Copy Markdown
Contributor

kowshikRoy commented Jul 14, 2025 •
edited
Loading

Thanks for pointing out the error. Please update the relevant testdata too.

@whtung
(update testdata)Replace CRL Distribution Points oid(2.5.29.31) with …
57220db 
…Issuing Distribution Point oid(2.5.29.28) when checking crl extension validity
@whtung
Copy link
Copy Markdown
Contributor Author

whtung commented Jul 15, 2025 •
edited
Loading

Hi Repon,

Thanks for your suggestion.

I have updated this testdata: crl_with_valid_extensions.pem.

I also attach these files in this comment for your information:
PR-974.zip

  1. gen_test_crl.go
    I re-generate testdata through this file. (also thanks for your guidance)
    I don't push this file into github.

  2. test-result

    CrlDistribtuionPoint.log: use original crl_with_valid_extensions.pem (run TestCRLExtensionsValidity only)-> It will lead to a test failure.
    IssuingDistribtuionPoint.log: use updated crl_with_valid_extensions.pem (run TestCRLExtensionsValidity only)-> The test will pass successfully.
    zlint-test_all.log: use updated crl_with_valid_extensions.pem and test all zlint tests -> The test will pass successfully.

@kowshikRoy
Copy link
Copy Markdown
Contributor

kowshikRoy commented Jul 21, 2025

@christopher-henderson Could you please review this CL?

@christopher-henderson christopher-henderson merged commit 5b6b916 into zmap:master Jul 27, 2025
3 of 4 checks passed
@aarongable aarongable mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopher-henderson christopher-henderson christopher-henderson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@whtung @kowshikRoy @christopher-henderson