set IneffectiveDate for w_sub_ca_aia_does_not_contain_issuing_ca_url#972
Merged
christopher-henderson merged 1 commit intozmap:masterfrom Jul 12, 2025
Merged
set IneffectiveDate for w_sub_ca_aia_does_not_contain_issuing_ca_url#972christopher-henderson merged 1 commit intozmap:masterfrom
christopher-henderson merged 1 commit intozmap:masterfrom
Conversation
christopher-henderson
approved these changes
Jul 12, 2025
Member
There was a problem hiding this comment.
Thank you @mhyder13!
- Thank you for tackling this issue.
- Thank you for your patience over the holiday
- Thank you for hunting down the precise diffs. Indeed, this activity is 90% of what I do in this repo and it's not the most fun thing in the world.
I agree that a deprecation of the lint on the 2.0.0 suffices for this change. That is to say, no new lint is necessary as the MAY language would result in a PASS in either scenario where the URL either does-or-does-not exist.
...make it a bit more like a real CA cert.
Thank you for considering this! The test certs are intended to be incredibly specific to the one requirement that they are exercising. As such, the rest of the cert can be of any shape-and-content that is reasonable. For my part, I like to leave little easter eggs such as song lyrics or quotes from old cartoons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to fix #956. It sets an
IneffectiveDatefor this lint for when this requirement was removed from the BRs to maintain backwards compatibility. I've also included a test with a certificate with a notBefore one second after theIneffectiveDate. That test cert is a sample cert modified to trigger this lint. I ran manual before-and-after tests with it to verify that it does trigger the warning without the patch. I'm confident has sufficient fidelity for this use, but let me know if you'd like to clean up any any component to make it a bit more like a real CA cert.I traced back the changes, and it looks like this requirement was removed from the BRs in v2.0.0 as part of the profile rework. You can see the new MAY requirement that replaced it in § 7.1.2.10.3 and the old SHOULD in the previous v1.8.7 §7.1.2.2(c). (That section was also rewritten from the language cited in the lint in v1.7.1, but that revision kept the SHOULD requirement, now phrased as
It SHOULD contain the HTTP URL of the Issuing CA’s certificate (accessMethod = 1.3.6.1.5.5.7.48.2).) Note that 2.0.0 is the revision immediately following 1.8.7.