Add lint to check for HTTP URLs in the AIA extension of Subordinate CA certificates#968
Merged
christopher-henderson merged 38 commits intozmap:masterfrom Jun 29, 2025
Merged
Conversation
Added //nolint:all to comment block to avoid golangci-lint to complain about duplicate words in comment
Fixed import block
Fine to me. Co-authored-by: Christopher Henderson <[email protected]>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
Added CABFEV_Sec9_2_8_Date
christopher-henderson
approved these changes
Jun 29, 2025
Member
christopher-henderson
left a comment
christopher-henderson
left a comment
There was a problem hiding this comment.
Thank you for the simple lint and for the thoughtful consideration towards backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint checks that, in the AIA extension of a Subordinate CA certificate, the URL (accessLocation) associated with the 'caIssuers' and 'ocsp' access methods be an HTTP URL (other schemes are not allowed by the CABF BRs).
A similar lint already exists in Zlint, but - apart from having a rather misleading name - it is very old and consequently it just generates a warning that might be ignored by some CA systems (depending on how they use Zlint). This lint, on the other hand, refers to CABF BR 2.0+ which only allow the "http" scheme, and therefore generates an error in case the certificate fails to meet the requirement. This type of error has been made in the generation of some fairly recent CA certificates (see Bugzilla).