Add lint to check CRL Number range#964
Merged
christopher-henderson merged 5 commits intozmap:masterfrom Jun 19, 2025
Merged
Conversation
christopher-henderson
requested changes
Jun 15, 2025
Member
christopher-henderson
left a comment
christopher-henderson
left a comment
There was a problem hiding this comment.
Just a small request on a big API usage.
| Details: fmt.Sprintf("CRL number is negative: %v", c.Number), | ||
| } | ||
| } | ||
| crlNumberUpperBound := new(big.Int).Lsh(big.NewInt(1), 159) |
There was a problem hiding this comment.
Suggested change
| crlNumberUpperBound := new(big.Int).Lsh(big.NewInt(1), 159) | |
| crlNumberUpperBound := new(big.Int).Exp(big.NewInt(2), big.NewInt(159), big.NewInt(0)) |
If you wouldn't mind, I find this a bit more readable due being a closer mapping to the literal language. Were it not for the extra modulus parameter then it would be a direct mapping.
This Go Playground indicates that this generates the same number.
christopher-henderson
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.