Add lint to check for mandatory individual identity subject attributes in non-legacy IV and SV S/MIME certificates#958
Merged
christopher-henderson merged 36 commits intozmap:masterfrom Jun 1, 2025
Conversation
Added //nolint:all to comment block to avoid golangci-lint to complain about duplicate words in comment
Fixed import block
Fine to me. Co-authored-by: Christopher Henderson <[email protected]>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
Added CABFEV_Sec9_2_8_Date
christopher-henderson
approved these changes
Jun 1, 2025
Member
christopher-henderson
left a comment
christopher-henderson
left a comment
There was a problem hiding this comment.
Very clean lint, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAB Forum's Baseline Requirements for S/MIME Certificates include the following provision:
...for both Individual-Validated and Sponsor-Validated certificates (see sections 7.1.4.2.5 and 7.1.4.2.6 of CABF SMIME BRs).
I realized that Zlint was lacking a check for this, so I am proposing this lint to fill the gap.