Please add lint to check for deprecated "legacy generation" S/MIME policy OIDs#957
Merged
christopher-henderson merged 40 commits intozmap:masterfrom Jun 1, 2025
Merged
Conversation
Added //nolint:all to comment block to avoid golangci-lint to complain about duplicate words in comment
Fixed import block
Fine to me. Co-authored-by: Christopher Henderson <[email protected]>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
Added CABFEV_Sec9_2_8_Date
christopher-henderson
approved these changes
Jun 1, 2025
| } | ||
|
|
||
| func (l *LegacyGenerationDeprecated) Execute(c *x509.Certificate) *lint.LintResult { | ||
| return &lint.LintResult{ |
Member
There was a problem hiding this comment.
Well this might the easiest lint the codebase lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of the CAB Forum's SMC08 ballot (https://cabforum.org/2024/07/15/ballot-smc08-deprecate-legacy-generation-profiles-and-minor-updates/) the "legacy generation" of S/MIME certificates has been deprecated: effective July 15, 2025...
This lint just checks that an S/MIME certificate issued on or after the SMC08 effective date does not have a legacy certificate policy OID. Further checks should also be done, starting from that date, but they are better handled by separate lints.