qcstatem pds must have https only#935
Merged
christopher-henderson merged 42 commits intozmap:masterfrom May 4, 2025
Merged
Conversation
christopher-henderson
requested changes
Apr 26, 2025
Member
christopher-henderson
left a comment
christopher-henderson
left a comment
There was a problem hiding this comment.
Thank you, as always, for the clear citation and tests!
It appears that you accidentally committed h which looks like the commit history of the repo. If you delete that then I believe that this lint is clear to land.
| qcEuPDS := &util.IdEtsiQcsQcEuPDS | ||
|
|
||
| ext := util.GetExtFromCert(c, util.QcStateOid) | ||
| s := util.ParseQcStatem(ext.Value, *qcEuPDS) |
There was a problem hiding this comment.
nit that you take the address of util.IdEtsiQcsQcEuPDS at L95 only to dereference it here
Suggested change
| s := util.ParseQcStatem(ext.Value, *qcEuPDS) | |
| s := util.ParseQcStatem(ext.Value, util.IdEtsiQcsQcEuPDS) |
Contributor
Author
There was a problem hiding this comment.
Thx! Your comments are addressed.
V
Co-authored-by: Christopher Henderson <[email protected]>
christopher-henderson
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint checks that the URL to a PDS document uses the "https" (https://) scheme. This is a requirement from the ETSI Specification ETSI EN 319 412-5 V2.4.1:
[...] As a minimum, a URL to a PDS provided in this statement shall use the "https" (https://) scheme, IETF RFC 2818 [5] or later documents updating this specification.[...]
This PR was developed in close collaboration with Deutsche Telekom Security, who also sponsored its development.