fix: organizationUnitName is prohibited#903
Merged
christopher-henderson merged 3 commits intozmap:masterfrom Dec 16, 2024
XolphinMartijn:noOU
Merged
fix: organizationUnitName is prohibited#903christopher-henderson merged 3 commits intozmap:masterfrom XolphinMartijn:noOU
christopher-henderson merged 3 commits intozmap:masterfrom
XolphinMartijn:noOU
Conversation
XolphinMartijn
changed the title
christopher-henderson
requested changes
Dec 14, 2024
Member
christopher-henderson
left a comment
christopher-henderson
left a comment
There was a problem hiding this comment.
Gosh, the wording/layout of this section is confusing. You have to be very careful to notice that this is the only field that is prohibited.
Looks good to me. Just please update the integration tests. The following one-liner ran from zlint/v3 will run this lint on the corpus and update the expectations file.
make integration INT_FLAGS="-overwriteExpected -lintFilter='e_ev_extra_subject_attribs'"
Contributor
Author
|
@christopher-henderson Thanks! I had missed the integration-test failure notice |
christopher-henderson
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #902, which had the prohibited OU field included in the allow list