Add lint to check for a valid Registration Scheme in the Subject.organizationIdentifier of EV certificates#901
Merged
christopher-henderson merged 36 commits intozmap:masterfrom Dec 10, 2024
Conversation
Added //nolint:all to comment block to avoid golangci-lint to complain about duplicate words in comment
Fixed import block
Fine to me. Co-authored-by: Christopher Henderson <[email protected]>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
Added CABFEV_Sec9_2_8_Date
christopher-henderson
requested changes
Dec 8, 2024
christopher-henderson
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lint verifies that the
organizationIdentifierSubject attribute in an EV certificate, if present, meets the requirement that...This requirement was first introduced in section 9.2.8 of EVGL 1.7.0 and subsequently moved to section 7.1.4.2 when the EVGL were restructured.
Appendix H only allows three registration schemes: VAT, NTR, PSD. If the actual registration scheme found in the
organizationIdentifierattribute is not one of those, this lint returns an Error.Note: There are no such cases in the Zlint test corpus, however a search on Censys shows that some cases do exist.