Upgrade Golang and tooling to fix the linter (#971)

christopher-henderson · web-flow · commit 4b2f3ab82e53 · 2025-06-29T13:14:46.000-07:00
* Upgrade golang and tooling

* upgrade go

* how did the linter itself die

* satisfy linter
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -16,7 +16,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v2
       with:
-        go-version: ^1.18
+        go-version: ^1.24
 
     - name: Check out code
       uses: actions/checkout@v2
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v2
       - name: Install golangci-lint
         run: |
-          VERSION=1.62.0
+          VERSION=1.64.8
           wget https://github.com/golangci/golangci-lint/releases/download/v${VERSION}/golangci-lint-${VERSION}-linux-amd64.tar.gz
           tar zxvf golangci-lint-${VERSION}-linux-amd64.tar.gz
           mv golangci-lint-${VERSION}-linux-amd64/golangci-lint . 
diff --git a/v3/cmd/genTestCerts/go.mod b/v3/cmd/genTestCerts/go.mod
@@ -1,8 +1,6 @@
 module github.com/zmap/zlint/v3/cmd/genTestCerts
 
-go 1.23.0
-
-toolchain go1.23.6
+go 1.24.0
 
 replace github.com/zmap/zlint/v3 => ../../
 
diff --git a/v3/cmd/gen_test_crl/go.mod b/v3/cmd/gen_test_crl/go.mod
@@ -1,8 +1,6 @@
 module github.com/zmap/zlint/v3/cmd/gen_test_crl
 
-go 1.23.0
-
-toolchain go1.23.6
+go 1.24.0
 
 replace github.com/zmap/zlint/v3 => ../../
 
diff --git a/v3/go.mod b/v3/go.mod
@@ -1,8 +1,6 @@
 module github.com/zmap/zlint/v3
 
-go 1.23.0
-
-toolchain go1.23.6
+go 1.24.0
 
 require (
 	github.com/kr/text v0.2.0 // indirect
diff --git a/v3/lint/configuration_test.go b/v3/lint/configuration_test.go
@@ -1108,7 +1108,7 @@ func TestConfigFromFile(t *testing.T) {
 		A *Test
 		B bool
 	}
-	f, err := os.CreateTemp("", "")
+	f, err := os.CreateTemp(t.TempDir(), "")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1141,7 +1141,7 @@ B = true
 }
 
 func TestBadConfigFromFile(t *testing.T) {
-	f, err := os.CreateTemp("", "")
+	f, err := os.CreateTemp(t.TempDir(), "")
 	if err != nil {
 		t.Fatal(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -1108,7 +1108,7 @@ func TestConfigFromFile(t *testing.T) {`
`1108`	`1108`	`A *Test`
`1109`	`1109`	`B bool`
`1110`	`1110`	`}`
`1111`		`- f, err := os.CreateTemp("", "")`
	`1111`	`+ f, err := os.CreateTemp(t.TempDir(), "")`
`1112`	`1112`	`if err != nil {`
`1113`	`1113`	`t.Fatal(err)`
`1114`	`1114`	`}`
`@@ -1141,7 +1141,7 @@ B = true`
`1141`	`1141`	`}`
`1142`	`1142`
`1143`	`1143`	`func TestBadConfigFromFile(t *testing.T) {`
`1144`		`- f, err := os.CreateTemp("", "")`
	`1144`	`+ f, err := os.CreateTemp(t.TempDir(), "")`
`1145`	`1145`	`if err != nil {`
`1146`	`1146`	`t.Fatal(err)`
`1147`	`1147`	`}`