deps: remove govalidator dep by adopting IsURL.#199
Merged
zakird merged 1 commit intozmap:masterfrom Jul 26, 2019
Merged
Conversation
Since the MIT and Apache licenses are compatible[0] the `zcrypto` project can avoid a larger dependency on the entire `github.com/asaskevich/govalidator` library by simply adopting the one function used: `IsURL`. This commit places that function in `util/isURL.go` with the original MIT license header, removes the dependency on `govalidator` and updates the `zcrypto` LICENSE file to reference the MIT license for `util/isURL.go` similar to the manner that the adopted Google code's license is referenced. IANAL but I believe this is all copacetic. [0]: https://law.stackexchange.com/questions/6081/can-i-bundle-mit-licensed-components-in-a-apache-2-0-licensed-project
zakird
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the MIT and Apache licenses are compatible the
zcryptoproject can avoid a larger dependency on the entiregithub.com/asaskevich/govalidatorlibrary by simply adopting the one function used:IsURL.This commit places that function in
util/isURL.gowith the original MIT license header, removes the dependency ongovalidatorand updates thezcryptoLICENSE file to reference the MIT license forutil/isURL.gosimilar to the manner that the adopted Google code's license is referenced.IANAL but I believe this is all copacetic.
Resolves #187