feat: adds unpinned-uses support to composite actions#364
Merged
woodruffw merged 2 commits intozizmorcore:mainfrom Dec 26, 2024
Merged
feat: adds unpinned-uses support to composite actions#364woodruffw merged 2 commits intozizmorcore:mainfrom
woodruffw merged 2 commits intozizmorcore:mainfrom
Conversation
Member
|
Looks good to me! Feel free to dedupe here or in a follow-up, whatever you prefer 🙂 |
Contributor
Author
|
Follow-up then, so I have room to get more used to the new CompositeStep APIs 🙂. I'll take a self-note to revisit this one! |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #350
I tried to dedup a bit the inner logic for this audit by extracting at least one common function. I do think there is room for more deduplication, but I did not want to push hard on that in the first take.
Let me know your thoughts 🙂